optimize useQuery result handling
#11954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage shows that this code path was never hit - in the case of a `standby` fetchPolicy, `resultData.current` would already have been reset in `useResubscribeIfNecessary`
While there are three code paths to `toQueryResult`, the other two are guaranteed to never have an `errors` property
instead, we calculate and memoize an "override result" in `useObservableSubscriptionResult`
🦋 Changeset detectedLatest commit: 2456a9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
phryneas
force-pushed
the
pr/useQuery-result-handling
branch
from
0eaf524
to
4161379
Compare
jerelmiller
approved these changes
Jul 12, 2024
| * @deprecated This property will be removed in a future version of Apollo Client. | ||
| * Please use `error.graphQLErrors` instead. | ||
| */ | ||
| errors?: ReadonlyArray<GraphQLFormattedError>; |
There was a problem hiding this comment.
Can we get a changeset for this change? I think we're fine without one for the refactor changes, but since this is external facing, it would be great to call this out 🙂
src/react/hooks/useQuery.ts
Outdated
Comment on lines
64
to
68
| interface InternalQueryResult<TData, TVariables extends OperationVariables> | ||
| extends Omit< | ||
| QueryResult<TData, TVariables>, | ||
| Exclude<keyof ObservableQueryFields<TData, TVariables>, "variables"> | ||
| > { | ||
| [originalResult]: ApolloQueryResult<TData>; | ||
| } | ||
| > {} |
There was a problem hiding this comment.
[nit] Since this is now empty, can we convert this to a type and assign to it rather than extend?
type InternalQueryResult<TData, TVariables extends OperationVariables> = Omit<
QueryResult<TData, TVariables>,
Exclude<keyof ObservableQueryFields<TData, TVariables>, "variables">
>
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of
useHandleSkip, which mutated results during render, among a few other optimizations. Please review Commit by Commit.